Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta.tests): Refactor VerifySpecificPath test case #965

Merged
merged 11 commits into from
Jan 28, 2025
Merged

refactor(anta.tests): Refactor VerifySpecificPath test case #965

merged 11 commits into from
Jan 28, 2025

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Dec 13, 2024 •
edited
Loading

Description

Refactoring PathSelection (VerifySpecificPath) tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #965 will not alter performance

Comparing geetanjalimanegslab:feat_verify_route_path (47ebd70) with main (461fa69)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum mentioned this pull request Dec 16, 2024
Closed
32 tasks
@gmuloc gmuloc added this to the v1.3.0 milestone Dec 24, 2024
vitthalmagadum
vitthalmagadum requested changes Dec 26, 2024
View reviewed changes
@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 7, 2025 09:11
gmuloc
gmuloc requested changes Jan 14, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@geetanjalimanegslab geetanjalimanegslab marked this pull request as draft January 15, 2025 14:48
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 15, 2025 16:21
gmuloc
gmuloc requested changes Jan 21, 2025
View reviewed changes
@gmuloc gmuloc changed the title fix(anta.tests): VerifySpecificPath testcase with the latest changes refactor(anta.tests): Refactor VerifySpecificPath test case Jan 28, 2025
gmuloc
gmuloc approved these changes Jan 28, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 1dd5a60 into aristanetworks:main Jan 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@vitthalmagadum vitthalmagadum vitthalmagadum approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@geetanjalimanegslab geetanjalimanegslab

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geetanjalimanegslab @gmuloc @vitthalmagadum